Skip to content

[16.0][FIX] payroll_contract_advantages: enforce unique advantage template per contract #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CristianoMafraJunior wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] payroll_contract_advantages: enforce unique advantage template per contract #213

CristianoMafraJunior wants to merge 1 commit into from
+8 −0

Conversation

@CristianoMafraJunior
Copy link
Member

@CristianoMafraJunior CristianoMafraJunior commented Sep 21, 2025 •
edited
Loading

Problem

The model hr.contract.advantage allowed duplicate records with the same contract_id and advantage_template_id

cc @kaynnan @marcelsavegnago @WesleyOliveira98

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 21, 2025

Hi @nimarosa,
some modules you are maintaining are being modified, check this out!

kaynnan
kaynnan approved these changes Sep 26, 2025
View reviewed changes
Copy link

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 26, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kaynnan
Copy link

kaynnan commented Sep 28, 2025

ping @OCA/payroll-maintainers

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Oct 3, 2025

ping @OCA/payroll-maintainers

@CristianoMafraJunior
Copy link
Member Author

CristianoMafraJunior commented Nov 3, 2025

ping @nimarosa

@CristianoMafraJunior
Copy link
Member Author

CristianoMafraJunior commented Jan 11, 2026

ping @OCA/payroll-maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

+3 more reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@kaynnan kaynnan kaynnan approved these changes

@WesleyOliveira98 WesleyOliveira98 WesleyOliveira98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CristianoMafraJunior @OCA-git-bot @kaynnan @marcelsavegnago @rvalyi @WesleyOliveira98